Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hamburger icon needs to be replaced with close icon #390 #392

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

kapilG0
Copy link
Contributor

@kapilG0 kapilG0 commented Aug 8, 2024

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #390

Type of change

Please give a X on it which is applicable

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor Code
  • A documentation update
  • Others(mentioned in the issue number)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test A Describe here

Test B Describe here (if Requred)

Screenshots and Videos:

PopShop.-.Google.Chrome.2024-08-08.17-13-24.mp4

Checklist:

Give a X on, which is applicable

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pop-shop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 11:45am

Copy link
Owner

@pooranjoyb pooranjoyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @kapilG0! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@pooranjoyb pooranjoyb merged commit 8e66120 into pooranjoyb:dev Aug 9, 2024
3 checks passed
@pooranjoyb pooranjoyb assigned kapilG0 and Mahitej28 and unassigned Mahitej28 Aug 9, 2024
@pooranjoyb pooranjoyb added ui Improvements of User Interface level1 Issue with difficulity level 1 gssoc Girlscript Summer of Code 2024 labels Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc Girlscript Summer of Code 2024 level1 Issue with difficulity level 1 ui Improvements of User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Hamburger icon needs to be replaced with close icon
3 participants