Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rating display dynamically #393

Merged
merged 3 commits into from
Aug 10, 2024
Merged

Conversation

Varsani2520
Copy link
Contributor

now in popshop website rating display from the supabase database instead of static value

Fixes #384

Type of change

Please give a X on it which is applicable

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor Code
  • A documentation update
  • Others(mentioned in the issue number)

Screenshots and Videos:

image
image

Checklist:

Give a X on, which is applicable

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pop-shop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2024 3:11pm

Copy link
Owner

@pooranjoyb pooranjoyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Varsani2520! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@Varsani2520
Copy link
Contributor Author

@pooranjoyb,merged it

@Varsani2520
Copy link
Contributor Author

@pooranjoyb ,please merged it

@Varsani2520
Copy link
Contributor Author

@pooranjoyb plz merged it

@pooranjoyb
Copy link
Owner

conflicts :/
Resolve them :)

@Varsani2520
Copy link
Contributor Author

@pooranjoyb ,i solved the conflicts ,now ready to merged

@pooranjoyb pooranjoyb merged commit 8563032 into pooranjoyb:dev Aug 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] we can add rating value in supabase
2 participants