Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added vertical margin to nav items #633

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

whoisveroniica
Copy link

Resolves #612 by adding vertical margin to navigation items.

Margin value was picked to match jump to section margin value, mentioned in the issue.

Branch cotaines one failing test although, it also occurs in the main branch. So I decided to leave it as-is.

Below I attached screenshots showing before and after.

Desktop before Desktop after
p5 - original p5 - padding
Mobile before Mobile after
p5mobile - original p5mobile - padding

@davepagurek
Copy link
Collaborator

Somewhere we have a breakpoint adding a min-height to the main nav so that when the window height is small, we don't get scroll bars on the main nav, just on the section nav below it. Do we need to update that min height here too? Currently I believe it's 350px, might need to be increased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Main navigation items are squeezed together
2 participants