-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Revamp build system to overcome Cross issues #670
Conversation
f5b6764
to
c3be84b
Compare
c3be84b
to
ca0700a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this amazing revamp! Great to see everything is building.
This commit completely refactor the build system for akri: - Rust components are now built within docker using XX for cross-compilation - Made samples clear in a separate Makefile to ease with them getting out of the main repo soon - Remove cross intermediate image - Use buildx to build for multiple architectures - Merge largely similar Dockerfiles - Upgrade opcua-monitoring-broker to .NET 6 - Upgrade opencv intermediate image to .NET 6 (the onvif broker still needs migration) Signed-off-by: Nicolas Belouin <[email protected]>
Signed-off-by: Nicolas Belouin <[email protected]>
721e650
to
6e66ea8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for revamping this. One ignorable nit on file rename but LGTM!
Co-authored-by: Kate Goldenring <[email protected]> Signed-off-by: Nicolas Belouin <[email protected]>
Also fix the built component always set to agent. Signed-off-by: Nicolas Belouin <[email protected]>
Signed-off-by: Nicolas Belouin <[email protected]>
6746707
to
019748e
Compare
this is an incredible improvement!! super awesome. from a quick glance, it looks like build times increase a bit ... if that's correct, i just want to make sure that isn't a problem for anything (this may be an outdated recollection, but i have vague memories about the test pipeline having a sleep to wait for some build part to finish: here). maybe some of the .github/actions code can be removed as well? |
Signed-off-by: Nicolas Belouin <[email protected]>
I increased the sleep you mentioned to be the maximum allowed run time for the build job, this way we are sure it won't cause any issue (also increased maximum run time for the run-test-cases job to take this change into account).
I forgot to remove them, they are all unneeded now, so they are all removed now. |
9fb822b
to
53eadfa
Compare
Signed-off-by: Nicolas Belouin <[email protected]>
53eadfa
to
7089261
Compare
/version patch |
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
What this PR does / why we need it:
This PR completely refactor the build system for akri, aiming to fix #656 :
Special notes for your reviewer:
If applicable:
cargo fmt
)cargo build
)cargo clippy
)cargo test
)cargo doc
)