Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump criterion to 0.5 to avoid dependency on atty #28

Merged
merged 1 commit into from
May 5, 2024
Merged

Bump criterion to 0.5 to avoid dependency on atty #28

merged 1 commit into from
May 5, 2024

Conversation

Pi-Cla
Copy link
Contributor

@Pi-Cla Pi-Cla commented Mar 22, 2024

Criterion before 0.5 depended on atty which is affected by RUSTSEC-2021-0145

alerque
alerque requested changes Mar 23, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@Pi-Cla
Bump criterion to 0.5 to avoid dependency on atty
3d0cfb9 
Criterion before 0.5 depended on atty which is affected
by [RUSTSEC-2021-0145](https://rustsec.org/advisories/RUSTSEC-2021-0145)
alerque
alerque approved these changes Mar 23, 2024
View reviewed changes
Copy link
Collaborator

@alerque alerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the update. Now just waiting on #27. As soon as a safe-harbor release goes out I'll test this. Since it's a developer-only dependency and not affecting downstream apps I think it's okay not to rush this.

@alerque alerque merged commit 5940158 into projectfluent:main May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alerque alerque alerque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pi-Cla @alerque