Updated SDK docs on output #313
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version was technically correct in that you shouldn't create resources within an apply function but was incorrect that it is not allowed
pierskarsenbarg
added
the
impact/no-changelog-required
|
See also pulumi/pulumi#16885 |
tgummerer
approved these changes
Nov 6, 2024
| @@ -496,7 +496,7 @@ public Output<U> Apply<U>(Func<T, Input<U>?> func) | |||
| /// name="func"/>. The result remains an <see cref="Output{T}"/> so that dependent resources | |||
| /// can be properly tracked. | |||
| /// <para/> | |||
| /// <paramref name="func"/> is not allowed to make resources. | |||
| /// <paramref name="func"/> should not be used to create resources unless necessary. Creating resources within 'func' can cause unknown behaviour. | |||
There was a problem hiding this comment.
Suggested change
| /// <paramref name="func"/> should not be used to create resources unless necessary. Creating resources within 'func' can cause unknown behaviour. | |
| /// <paramref name="func"/> should not be used to create resources unless necessary as `func` may not be run during some program executions. |
Let's make it the same as in pulumi/pulumi#16885.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version was technically correct in that you shouldn't create resources within an apply function but was incorrect that it is not allowed