Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code and example for classifying snow effects #209

Merged
merged 84 commits into from
Oct 16, 2024
Merged
Show file tree
Hide file tree
Changes from 83 commits
Commits
Show all changes
84 commits
Select commit Hold shift + click to select a range
455a1ae
initial load of snow mode detection
cwhanse Apr 8, 2024
096d480
lint
cwhanse Apr 8, 2024
bfe3642
fix file opens
cwhanse Apr 8, 2024
14caa28
Merge branch 'main' of https://github.com/pvlib/pvanalytics into snow
cwhanse Apr 8, 2024
c0d47b3
add README
cwhanse Apr 8, 2024
eae4a84
formatting
cwhanse Apr 8, 2024
83592a2
fix import
cwhanse Apr 8, 2024
ac12f36
fix file name
cwhanse Apr 8, 2024
556fefc
fix up horizon code, add test
cwhanse Apr 8, 2024
025b74b
fix horizon file name
cwhanse Apr 8, 2024
acf0b4e
update mask function
cwhanse Apr 8, 2024
0b8720d
linting
cwhanse Apr 8, 2024
1f7a0d6
work toward vectorizing categorize
cwhanse Apr 9, 2024
e4e2219
lint, use mode None instead of -1
cwhanse Apr 9, 2024
fc2fd20
use None in test
cwhanse Apr 9, 2024
8a73eef
use dtype object to have both int and None
cwhanse Apr 9, 2024
32619fb
handle mixed types
cwhanse Apr 9, 2024
42e582a
add tests
cwhanse Apr 10, 2024
2af3fa0
handle equals
cwhanse Apr 10, 2024
9a1494c
Fixed the horizon masking section
eccoope Apr 15, 2024
3cc7c55
Linting
eccoope Apr 15, 2024
a4465b7
Added argument to test_categorize() to reflect changes made to catego…
eccoope Apr 15, 2024
4ad80cd
last lint i promise!
eccoope Apr 15, 2024
cb67705
remove old categorize
cwhanse Apr 17, 2024
6de642c
Fixed failing test
eccoope Apr 17, 2024
409a29e
Fixed failing test
eccoope Apr 17, 2024
c0d0a3f
fix offline
cwhanse Apr 17, 2024
6e93d0d
Merge branch 'snow' of https://github.com/cwhanse/pvanalytics into snow
cwhanse Apr 17, 2024
ccfac03
0 not None
cwhanse Apr 17, 2024
0d5c087
edit definitions of mode
cwhanse Apr 17, 2024
9a51cf9
use pvlib function, punctuation
cwhanse Apr 17, 2024
12159be
lint, add note at head
cwhanse Apr 18, 2024
91c9c7a
lint
cwhanse Apr 18, 2024
725240f
api, whatsnew
cwhanse Apr 18, 2024
8b309cb
implemented mode -1
eccoope Apr 29, 2024
c7daed4
fixed import error that failed readthedocs
eccoope Apr 29, 2024
3a3f54b
linting (W291 flags on snow.py)
eccoope Apr 29, 2024
9d8c508
more mode -1 changes
eccoope May 3, 2024
55ceafa
linting
eccoope May 3, 2024
41fdfe0
Fixing readthedocs rendering
eccoope May 6, 2024
5ef8e56
Merge branch 'main' into snow
cwhanse May 6, 2024
9abaac3
fixed failing test
eccoope May 6, 2024
d840741
Merge branch 'snow' of https://github.com/cwhanse/pvanalytics into pr…
eccoope May 6, 2024
f2dbcfe
Apply suggestions from code review
cwhanse May 15, 2024
55377fd
doc build
cwhanse May 15, 2024
f62d8d7
Merge branch 'snow' of https://github.com/cwhanse/pvanalytics into snow
cwhanse May 15, 2024
3da321f
spaces
cwhanse May 15, 2024
d0f3ebc
maybe its this extra line?
cwhanse May 16, 2024
097ec36
docstring edits
cwhanse May 16, 2024
88ee008
addressed Kevin's comments
eccoope Jun 4, 2024
69b431d
Merge branch 'snow' of https://github.com/cwhanse/pvanalytics into pr…
eccoope Jun 4, 2024
2090237
Fixed import statements
eccoope Jun 4, 2024
1ae4824
Uncomment directory definition
eccoope Jun 4, 2024
037b0bd
Removed unused import statement
eccoope Jun 24, 2024
8f382d5
Shorted line length to 79 characters
eccoope Jun 24, 2024
8d7de2e
resolved merge conflicts
eccoope Jun 25, 2024
e7ad7d2
Update pvanalytics/features/snow.py
eccoope Jun 27, 2024
5b96547
Update pvanalytics/features/snow.py
eccoope Jun 27, 2024
acf4aef
Update pvanalytics/features/snow.py
eccoope Jun 27, 2024
40ef5a2
Update pvanalytics/features/snow.py
eccoope Jun 27, 2024
86c451c
Madking changes recommended by Kevin
eccoope Jun 27, 2024
50e17da
Linting
eccoope Jun 27, 2024
b5335c6
changed name of hidden function in test
eccoope Jun 27, 2024
523ded3
Linting again
eccoope Jun 27, 2024
46f089d
put Bug fixes back in whatsnew
cwhanse Sep 9, 2024
6a7420a
fix merge
cwhanse Sep 9, 2024
e7be3a7
catchup with github changes
cwhanse Sep 9, 2024
741e721
doc improvements
cwhanse Sep 10, 2024
35cbb7c
save the file first
cwhanse Sep 10, 2024
ba1694f
adjust colors
cwhanse Sep 10, 2024
335478c
figure nidges
cwhanse Sep 10, 2024
be3eef5
figure nidges
cwhanse Sep 10, 2024
fff5452
Update docs/examples/snow-detection/snow-mode.py
cwhanse Sep 10, 2024
9dbc990
small edits
cwhanse Sep 27, 2024
4075739
Merge branch 'snow' of https://github.com/cwhanse/pvanalytics into snow
cwhanse Sep 27, 2024
8cd1fca
Apply suggestions from code review
cwhanse Sep 27, 2024
9335a74
overhaul example, remove horizon
cwhanse Oct 2, 2024
72f5066
Merge branch 'main' of https://github.com/pvlib/pvanalytics into snow
cwhanse Oct 7, 2024
1d221ca
edits, I forget what
cwhanse Oct 7, 2024
7c80d3a
major edits to example
cwhanse Oct 7, 2024
87da65c
yet more edits
cwhanse Oct 7, 2024
5356804
lint
cwhanse Oct 7, 2024
f9d9638
Update docs/api.rst
cwhanse Oct 7, 2024
d45be6a
review comments
cwhanse Oct 11, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion docs/api.rst
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ There is function for calculating the component sum for GHI, DHI,
and DNI, and correcting for nighttime periods. Using this function, we can
estimate one irradiance field using the two other irradiance fields.
This can be useful for comparison, as well as to
calculate missing data fields.
calculate missing data fields.

.. autosummary::
:toctree: generated/
Expand Down Expand Up @@ -269,6 +269,19 @@ Functions for labeling shadows.

features.shading.fixed

Snow
----

Functions for identifying and quantifying the effects of snow.

.. autosummary::
cwhanse marked this conversation as resolved.
Show resolved Hide resolved
:toctree: generated/

features.snow.get_irradiance_sapm
features.snow.get_irradiance_imp
features.snow.categorize
features.snow.get_transmission
kandersolar marked this conversation as resolved.
Show resolved Hide resolved

System
======

Expand Down
4 changes: 4 additions & 0 deletions docs/examples/snow-detection/README.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Snow
----

Examples for identifying the effects of snow.
Loading
Loading