Update for sdk-34 #5
Conversation
Dockerfile
Outdated
| ARG ANDROID_SDK_TOOLS_TAGGED="latest" | ||
| ARG ANDROID_SDK_TOOLS_VERSION="9123335" | ||
| ARG ANDROID_SDK_TOOLS_VERSION="6609375" |
There was a problem hiding this comment.
just curious where you find this specific number? I thought it was the latest from developer android website, which is different right now
There was a problem hiding this comment.
I got this from here https://github.com/GoogleChromeLabs/bubblewrap/blob/main/packages/cli/src/lib/AndroidSdkToolsInstaller.ts#L22, but yeah this is weird. Hmmm
There was a problem hiding this comment.
I see, the commit is 4 years old, if you see the current android-build-box it has a comment (that I think can be a great addition to this part... including a similar comment)
recent number is 11.xxx.xxx as well
Co-authored-by: Maicon Carraro <[email protected]>
| @@ -1,10 +1,12 @@ | |||
| platforms:android-34 | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
probably you'll need to update here as well:
docker-android-build-box/Dockerfile
Line 461 in 6df1ffc
No description provided.