-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --categories option to work with requirements txt files #5826
Conversation
@matteius I looked into the |
@DasaniT Yeah that makes sense -- but in the mean time can you fix the CI lint (ignore the ruff job) so that the CI runner can run the tests portion? |
@matteius I ran |
Change the backticks to `` instead of ` for your news comment :) |
00ecad6
to
29cf63e
Compare
Thanks for your help, and sorry somehow I couldn't find the failed test:) I fixed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The linked issue is a pattern that I am very familiar with.
Darn, there were more conflicts with my branch than were reported. Edit: Sorry, couldn't think, it was exactly what was reported but confused the heck out of me, but I think I got it now. |
The issue
Fixes #5722
The fix
changed the
import_requirements()
and related functions to have categories.--categories
now works with requirements file. whether-r <req_path>
is provided or not (when only requirements.txt is available)The checklist
news/
directory to describe this fix with the extension.bugfix.rst
,.feature.rst
,.behavior.rst
,.doc.rst
..vendor.rst
. or.trivial.rst
(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.