Fix usage of format_help #5872
Merged
Fix usage of format_help #5872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteius
reviewed
Aug 26, 2023
| @@ -71,8 +71,7 @@ def unnest(elem: Iterable) -> Any: | |||
| for el in target: | |||
| if isinstance(el, Iterable) and not isinstance(el, str): | |||
| el, el_copy = tee(el, 2) | |||
| for sub in unnest(el_copy): | |||
| yield sub | |||
| yield from unnest(el_copy) | |||
There was a problem hiding this comment.
I actually have a bigger refactor/simplification of this method in my open PR that will conflict with this.
There was a problem hiding this comment.
Well. Then let's merge this with out caring for ruff. We'll fix ruff in the next PRs
matteius
approved these changes
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix how format_help is used.
Because it uses
click.echocolor strings, one should not useconsole.print.Fix #5869
Fix #5850