Respect thresholds in scaled months #365
Open
+6
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkarrmann
commented
Jun 3, 2024
| @@ -46,21 +46,23 @@ month: | |||
| ``` | |||
|
|
|||
| ### Colored by Values | |||
| Use parameter `circleColorByValue`, color the circles based on the values | |||
| Use parameters `circleColorByValue`, `yMin`, and `yMax`, to color the circles based on the values | |||
There was a problem hiding this comment.
I think it's worth emphasizing that you need to set all 3 of these in order for it to take effect.
mkarrmann
commented
Jun 3, 2024
| @@ -6,7 +6,7 @@ bloodpressure: 177/119 | |||
|
|
|||
| #weight:70.0kg | |||
|
|
|||
| #exercise-pushup:35 | |||
| #exercise-pushup:5 | |||
There was a problem hiding this comment.
This date should now have no circle, because it is beneath the threshold.
|
@pyrochlore FYI. I'd be interested to hear your thoughts on this / the underlying issue. P.S. thank you for the awesome project! Both very neat and useful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #364 for description. Ensures that the
monthgraph'sthresholdparameter, even whencircleColorByValueis also used.Fixes #364
Note that I just raised that issue myself, and it appears that the behavior I'm removing was added intentionally. So, I'd understand if this PR is rejected (although I would be curious to hear why it behaves the way it does).
Type of change
Please delete options that are not relevant.
How Has This Been Tested?