HeimdalRealm: fix missing comma in stash command #30

svmhdvn · 2024-06-17T16:47:40Z

No description provided.

jborean93 · 2024-06-17T20:00:07Z

Can you share what you are trying to fix, admin on Heimdal only documents --random-password and not --random-key for the stash command https://github.com/heimdal/heimdal/blob/1b57b62d82a478c1fade350f0fb1d57031a8734e/kadmin/kadmin-commands.in#L35-L70. I've also used the current code for Heimdal installs without issues as well so knowing what the underlying problem is will help with this review.

svmhdvn · 2024-06-17T20:10:16Z

Sorry, I didn't fully understand the issue before, but found the typo now.

Signed-off-by: Siva Mahadevan <[email protected]>

jborean93 · 2024-11-11T03:30:45Z

Oops sorry I missed actually merging this one in.

svmhdvn marked this pull request as draft June 17, 2024 17:16

svmhdvn force-pushed the patch-1 branch from dd7a1bd to 24cc392 Compare June 17, 2024 20:09

svmhdvn changed the title ~~HeimdalRealm: fix wrong --random-password to kstash cmd~~ HeimdalRealm: fix missing comma in stash command Jun 17, 2024

svmhdvn marked this pull request as ready for review June 17, 2024 20:09

jborean93 approved these changes Jun 17, 2024

View reviewed changes

HeimdalRealm: fix missing comma in stash command

5aa91ca

Signed-off-by: Siva Mahadevan <[email protected]>

svmhdvn force-pushed the patch-1 branch from 24cc392 to 5aa91ca Compare June 18, 2024 00:54

This was referenced Nov 5, 2024

heimdal: fix typo on kdb creation #33

Closed

typo in realm.py(676), HeimdalRealm #32

Closed

jborean93 merged commit 349b79e into pythongssapi:main Nov 11, 2024
1 check passed

Provide feedback