Add support for a deadline on clients #69
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slids
reviewed
Oct 18, 2024
| @@ -21,6 +21,9 @@ | |||
| (defvar *completion-queue* nil "The global completion queue used to | |||
| manage grpc calls.") | |||
|
|
|||
| (defvar *call-deadline* nil | |||
| "The deadline for a grpc call. The default, nil, specifies an infinite deadline") | |||
There was a problem hiding this comment.
I don't think this is something that should be a defvar, more something you specify, and the user can make a defvar and set in their code...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up a basic implementation for deadlines from grpc clients. This is roughly described in #68
Request for comments - what do we think of this implementation? is there a better way we can do it? My goal is to keep the syntax for setting the deadline relatively ergonomic in the code. Ideally we'd be able to add the other parameters to fill out the C signature for
grpc_channel_create_call(used here).Open TODO's: