Fix second level parent (no link / same link as child) #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
callingmedic911
commented
Apr 26, 2024
Comment on lines
-123
to
-141
| {subItem.links && ( | ||
| <Disclosure.Panel as="ul"> | ||
| {subItem.links.map((tertiary) => ( | ||
| <li key={tertiary.title}> | ||
| <Disclosure.Button | ||
| className={`${styles.button} ${styles.tertiary}`} | ||
| > | ||
| <Link | ||
| href={tertiary.href} | ||
| onClick={onLinkClick} | ||
| className={clsx(styles.item)} | ||
| > | ||
| {tertiary.title} | ||
| </Link> | ||
| </Disclosure.Button> | ||
| </li> | ||
| ))} | ||
| </Disclosure.Panel> | ||
| )} |
There was a problem hiding this comment.
We don't have tertiary level navigation, so removed it because I haven't tested my changes for tertiary level. We can revisit if we need tertiary navigation or more robust fix.
callingmedic911
force-pushed
the
aditya/fix-second-level-nagivation
branch
from
a3095f6
to
0d693db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PRO-289 and PRO-253.