What is time travel #124
Merged
What is time travel #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jonbell-lot23
approved these changes
Apr 28, 2024
There was a problem hiding this comment.
Looks good! I found the examples at the top to be really helpful for me, and I think there's a good amount of detail throughout.
The naive versus forking image could be improved but oh gosh do I have other things that are higher priority, so we'll let it be for now.
I committed a bunch of little typo, comma, weasel-word additions to tighten some things up.
|
This reads well and I think is overall an improvement, but I have some broader thoughts about the structure of our sidebar and the contents within that I think these page updates raise even further for me. Opening a new issue to discuss further |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a draft, but i think it does a good job of documenting many of the things we talk about when folks are interested in understanding the magic / mystery beind time travel.