Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log filter function to Grafana #603

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Log filter function to Grafana #603

merged 2 commits into from
Jul 5, 2024

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Jul 5, 2024

Before we remove the deprecated test filter config (#602) we should learn more about how many people are using it, and if it's possible for us to support all of their use cases with the new advanced upload config. This PR logs the filter function to Grafana.

Is this okay to do or should the contents of this function be considered private? I assume this function is unlikely to have sensitive info in it, and if there were any- it would be passed in via an env variable. But is that okay to assume?

Copy link

changeset-bot bot commented Jul 5, 2024

🦋 Changeset detected

Latest commit: 8924636

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@replayio/test-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

replay-io bot commented Jul 5, 2024

Status Complete ↗︎
Commit a6ce0e9
Results
2 Failed
  • clicks a disappearing button
  • should fail on this test
  • 42 Passed
  • adds items
  • adds new items using a custom command
  • adds todos following the fixture
  • adds todos following the fixture
  • adds todos following the fixture
  • adds todos following the fixture
  • calls inform
  • complete all checkbox should update state when items are completed / cleared
  • gets a number
  • only gets a number
  • only gets a number
  • should allow me to add todo items
  • should allow me to clear the complete state of all items
  • should allow me to display active items
  • should allow me to display all items
  • should allow me to display completed items
  • should allow me to edit an item
  • should allow me to mark all items as completed
  • should allow me to mark items as complete
  • should allow me to un-mark items as complete
  • should append new items to the bottom of the list
  • should be hidden when there are no items that are completed
  • should cancel edits on escape
  • should clear text input field when an item is added
  • should display the correct text
  • should display the current number of todo items
  • should focus on the todo input field
  • should hide #main and #footer
  • should hide other controls when editing
  • should highlight the currently applied filter
  • should intercept postman
  • should invoke some commands that have exceptional option handling
  • should log
  • should persist its data
  • should remove completed items when clicked
  • should remove the item if an empty text string was entered
  • should respect the back button
  • should save edits on blur
  • should show #main and #footer when items added
  • should trim entered text
  • should trim text input
  • yields a number
  • @bvaughn bvaughn merged commit f2b1c82 into main Jul 5, 2024
    7 checks passed
    @bvaughn bvaughn deleted the PRO-583-log-filter-fn branch July 5, 2024 15:17
    @github-actions github-actions bot mentioned this pull request Jul 5, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants