Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for proxy-based authentication #307

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

akmet
Copy link

@akmet akmet commented Nov 1, 2024

What is the purpose of this change? What does it change?

This change adds support for reverse-proxy-based authentication with private repositories.

It introduces the --proxy-auth-username flag, which allows users to specify the header name containing the username so that the server can handle the access on the specific repository.

Was the change discussed in an issue or in the forum before?

In #174 it was discussed that proxy-based authentication in combination with private repositories requires a header containing the username. For maximum compatibility, the name of this header should be configurable.

Checklist

  • I have enabled maintainer edits for this PR
  • I have added tests for all changes in this PR
  • I have added documentation for the changes (in the manual)
  • There's a new file in changelog/unreleased/ that describes the changes for our users (template here)
  • I have run gofmt on the code in all commits
  • All commit messages are formatted in the same style as the other commits in the repo
  • I'm done, this Pull Request is ready for review

Copy link
Contributor

@wojas wojas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants