Allow lineheight in font

[hackpirodev]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/riccardoperra/codeimage/blob/main/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[changeset-bot]

⚠️ No Changeset found

Latest commit: ef68a01

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

Deploy preview for codeimage-website-dev ready!

✅ Preview
https://codeimage-website-bi834nv70-riccardoperra.vercel.app
https://codeimage-website-pr-597.vercel.app

Built with commit ef68a01.
This pull request is being automatically deployed with vercel-action

[github-actions]

Deploy preview for codeimage-highlight-dev ready!

✅ Preview
https://codeimage-highlight-bnrw0e1ht-riccardoperra.vercel.app
https://codeimage-highlight-pr-597.vercel.app

Built with commit ef68a01.
This pull request is being automatically deployed with vercel-action

[github-actions]

Deploy preview for codeimage ready!

✅ Preview
https://codeimage-kly9dybgi-riccardoperra.vercel.app
https://codeimage-app-pr-597.vercel.app

Built with commit ef68a01.
This pull request is being automatically deployed with vercel-action

[riccardoperra]

Suggested change

	<>
	<pre>{editorState.options.lineHeight}</pre>
	<code class={`language-${selectedLanguage()?.id ?? 'default'}`}>
	<div ref={setRef} />
	</code>
	</>
	<>
	<code class={`language-${selectedLanguage()?.id ?? 'default'}`}>
	<div ref={setRef} />
	</code>
	</>

we've to remove this

[riccardoperra]

Suggested change

	.hold(store.commands.setLineHeight, (linheHeight, {set}) => {
	set('options', 'lineHeight', linheHeight);
	.hold(store.commands.setLineHeight, (lineHeight, {set}) => {
	set('options', 'lineHeight', lineHeight);

[riccardoperra]

i'd handle this separately to be more performant. createExtension will create a code mirror "compartment" then it will change only when lineHeight effectively changes.

createExtension(() => {
  const lineHeight = editor.lineHeight;
  if (!lineHeight) return null;
  return EditorView.theme({
    '.cm-content': { lineHeight }
  })
})

[riccardoperra]

we have to change it with NumberField of @codeui/kit when available.

riccardoperra/codeui#39

currently it's still in progress due to a Maskito bug with float numbers. I'll probably leave that solution

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.