-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update configure.ac and sync configure. #1594
base: master
Are you sure you want to change the base?
Conversation
configure
Outdated
--enable-multilib build both RV32 and RV64 runtime libraries | ||
[--disable-multilib] | ||
--enable-multilib build both RV32 and RV64 runtime libraries (only | ||
RV64 for musl libc) [--disable-multilib] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is caused by a forgotten change in configure.ac
.
Can you update configure.ac
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the new configure file is just generated by $ autoconf configure.ac
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got that, but with this PR we end up with a wrong message in configure
.
So, please fix configure.ac
(remove the "only RV64 for musl libc" there).
I see the in the And since now gcc supports vector extension, do we need to update the |
I would leave it as it is now.
Yes, but that's also out of this PR's scope (it should be a different PR). |
Or would Edit: my comment crossed with @cmuellner's previous one which renders mine moot... |
Okay, I will update them in the new PR. |
I don't mind changing the default. |
@TommyMurphyTM1234 It's up to the ISA spec version, when set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still needs the change in configure.ac
(removal of the "only RV64 for musl libc").
Understood! Update it with the new commit. |
Use autoupdate updates the configure.ac and sync the configure file with configure.ac with autoconf.