Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating tf2 C Headers #1325

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

CursedRock17
Copy link

Related to this pull request in geometry2 in which we deprecated the .h style headers in favor of .hpp.

Signed-off-by: CursedRock17 <[email protected]>
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CursedRock17 is this from rolling on? or does it affect Jazzy as well?

@CursedRock17
Copy link
Author

This is from rolling onward, there aren't any plans of back porting yet.

@saikishor
Copy link
Member

This is from rolling onward, there aren't any plans of back porting yet.

Thank you!

We will have to wait for the original PR to be merged and then we can get back to this.
In the meantime, Can you add conditioning in the code so that from rolling on it uses the .hpp, and in the prior versions it uses the .h version?

Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@saikishor saikishor marked this pull request as draft November 22, 2024 10:57
@saikishor
Copy link
Member

@CursedRock17 I changed this PR to draft for now. Once your original PR is merged, please mark it as ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants