-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] flag for jpeg compression of bayer format #98
base: rolling
Are you sure you want to change the base?
[ADD] flag for jpeg compression of bayer format #98
Conversation
is there any reason for not introducing this this parameter? |
conflicts are fairly simple and I will solve them, if the general idea is welcomed. |
Thanks for bringing it up again @andrei-ng :D However, different to the result in the issue mentioned, the bayer image is currently converted to a mono image prior to compression. |
@wodtko , thanks for the clarification. I haven't used ROS2 in this context. I hope that by the time I use it, your PR will be merged :) . |
Well, if anyone would review my changes, I would be happy to resolve any CI issues. |
4c2a8a5
to
8be68ec
Compare
8be68ec
to
b14c904
Compare
b14c904
to
d297944
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind to fix the conflicts?
a3700d2
to
b7873c1
Compare
b7873c1
to
01e38b7
Compare
All conflicts are fixed, and the number of lines changed was reduced. I would highly appreciate any review/merge. |
This PR adds a flag that allows for jpeg compression of Bayer encoded images.
Although I fully understand why one does not want a lossy compression of Bayer encoded image, it worked pretty well for us when testing it with multiple camera images.
We really want to use compressed Bayer images to get recordings smaller, e.g. we record 10Hz image_streams of 8 cameras with 3MP each.
With this PR there is no need for "inflating" the data to a color image prior to compression.