Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

One more cleanup pass #19

Merged
merged 14 commits into from
Aug 17, 2023
Merged

One more cleanup pass #19

merged 14 commits into from
Aug 17, 2023

Conversation

john-maidbot
Copy link
Collaborator

Hopefully this will be the last cleanup pass before deciding where to submit the ros2 port to.

Generally:

  1. Making sure the comments exist where necessary and are consistently formatted
  2. Making sure test coverage exists for relevant functionality
  3. Removing unneeded code or dependencies

@john-maidbot john-maidbot marked this pull request as ready for review August 17, 2023 14:10
@john-maidbot john-maidbot merged commit dc88529 into ros2 Aug 17, 2023
2 checks passed
@john-maidbot john-maidbot deleted the pre-release-cleanup branch August 17, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@john-maidbot