Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of python_cmake_module. #63

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

clalancette
Copy link
Contributor

This must be merged before ros2/ros2#1524 ; see that pull request for more information about this change.

@ahcorde
Copy link
Collaborator

ahcorde commented Feb 23, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor Author

This is another one that needs to wait for ros2/ci#755 to land before merging, as otherwise Windows Debug is going to break.

@clalancette clalancette marked this pull request as draft April 12, 2024 15:34
@clalancette clalancette force-pushed the clalancette/remove-python-cmake-module branch from c9b293b to 75f5fee Compare May 14, 2024 13:42
@clalancette clalancette force-pushed the clalancette/remove-python-cmake-module branch from 75f5fee to 332f024 Compare June 4, 2024 18:01
@clalancette clalancette force-pushed the clalancette/remove-python-cmake-module branch from 332f024 to ba4bb0d Compare June 25, 2024 13:22
Signed-off-by: Chris Lalancette <[email protected]>
@clalancette clalancette force-pushed the clalancette/remove-python-cmake-module branch from ba4bb0d to bf5e1f6 Compare September 21, 2024 23:20
@clalancette clalancette marked this pull request as ready for review October 3, 2024 18:14
@clalancette
Copy link
Contributor Author

CI for this (along with all of the rest of the changes needed) is in ros2/ros2#1524 (comment)

@clalancette clalancette merged commit 81d5d06 into rolling Oct 3, 2024
4 checks passed
@clalancette clalancette deleted the clalancette/remove-python-cmake-module branch October 3, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants