Mark any_instance proxy methods as private if they were private #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
force-pushed
the
fix-any-instance-private-method-visibility
branch
from
98d7241
to
e492850
Compare
JonRowe
force-pushed
the
fix-any-instance-private-method-visibility
branch
from
6330e3b
to
b9a7c04
Compare
JonRowe
added a commit
that referenced
this pull request
Oct 19, 2024
…isibility Mark any_instance proxy methods as private if they were private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
expect|allow_any_instance_of(...)we restored, and had tests for, method visibility such that private methods remained private after tests, but we did not actually make the proxy methods private... So when defining such methods we mark them as private if they were previously true forprivate_method_defined?, fixes #1584