ndk/audio: Merge AudioResult variant enum into AudioError
#467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
MarijnS95
force-pushed
the
audio-rework-result-enum
branch
from
07be268
to
ff6f361
Compare
rib
approved these changes
Jan 26, 2024
MarijnS95
force-pushed
the
audio-rework-result-enum
branch
from
ff6f361
to
fa72a15
Compare
MarijnS95
force-pushed
the
non-exhaustive-enums
branch
2 times, most recently
from
aea39d3
to
8216763
Compare
MarijnS95
force-pushed
the
audio-rework-result-enum
branch
from
fa72a15
to
a027321
Compare
MarijnS95
force-pushed
the
audio-rework-result-enum
branch
from
a027321
to
b823e22
Compare
Now that `UnsupportedValue` is no longer part of `AudioError` thanks to all enums having a proper `__Unknown(x)` catch-all (making the `enum` API a whole lot more convenient to users), this `#[error]` enum is just a wrapper struct with only one variant. Instead, drop `AudioError` and its `thiserror` wrapping completely, and import `Error` directly on the `aaudio_result_t` `enum` that is also renamed to `AudioError`.
MarijnS95
force-pushed
the
audio-rework-result-enum
branch
from
b823e22
to
c1494d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #459
Now that
UnsupportedValueis no longer part ofAudioErrorthanks to all enums having a proper__Unknown(x)catch-all (making theenumAPI a whole lot more convenient to users), this#[error]enum is just a wrapper struct with only one variant.Instead, drop
AudioErrorand itsthiserrorwrapping completely, and importErrordirectly on theaaudio_result_tenumthat is also renamed toAudioError.