Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dup script #589

Merged
merged 7 commits into from
Nov 24, 2019
Merged

dup script #589

merged 7 commits into from
Nov 24, 2019

Conversation

maelle
Copy link
Contributor

@maelle maelle commented Nov 22, 2019

cf #144

cc @jonocarroll

The script skips all lines after "upcoming events" (maybe not specific enough?) and removes the R code link.

@maelle maelle marked this pull request as ready for review November 22, 2019 14:58
@maelle
Copy link
Contributor Author

maelle commented Nov 22, 2019

Depending on #590 the script/function might end up in another repo.

@maelle
Copy link
Contributor Author

maelle commented Nov 22, 2019

I added a duplicate by hand in draft.md (ironic given all the ones I had mistakenly added today, and then removed) to check the function.

Copy link
Member

@jonocarroll jonocarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and does what it says on the tin. Cheers!

scripts/find_duplicates.R Show resolved Hide resolved
scripts/find_duplicates.R Outdated Show resolved Hide resolved
scripts/find_duplicates.R Show resolved Hide resolved
maelle and others added 3 commits November 23, 2019 05:47
Co-Authored-By: Jonathan Carroll <[email protected]>
Co-Authored-By: Jonathan Carroll <[email protected]>
Co-Authored-By: Jonathan Carroll <[email protected]>
@maelle
Copy link
Contributor Author

maelle commented Nov 23, 2019

what do you mean by current week @jonocarroll? The script looks for links in draft.md that also were in one of the issues from the 20 previous weeks.

@maelle
Copy link
Contributor Author

maelle commented Nov 23, 2019

One thing that script doesn't look for is duplicates within draft.md (same item under different headings), should it be added?

@jonocarroll
Copy link
Member

That's what the current_dups block does -- identifies duplicates within the draft.

@maelle
Copy link
Contributor Author

maelle commented Nov 23, 2019

Right! Thanks! Can we merge this and close the issue or should we get a second review?

@qinwf
Copy link
Member

qinwf commented Nov 23, 2019

LGTM.

If there are small changes in the future, we can push it directly or merge it after reviewed by one reviewer.

@maelle maelle merged commit ff24648 into gh-pages Nov 24, 2019
@maelle maelle deleted the dups branch November 24, 2019 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants