-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dup script #589
dup script #589
Conversation
Depending on #590 the script/function might end up in another repo. |
I added a duplicate by hand in draft.md (ironic given all the ones I had mistakenly added today, and then removed) to check the function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and does what it says on the tin. Cheers!
Co-Authored-By: Jonathan Carroll <[email protected]>
Co-Authored-By: Jonathan Carroll <[email protected]>
Co-Authored-By: Jonathan Carroll <[email protected]>
what do you mean by current week @jonocarroll? The script looks for links in draft.md that also were in one of the issues from the 20 previous weeks. |
One thing that script doesn't look for is duplicates within draft.md (same item under different headings), should it be added? |
That's what the |
Right! Thanks! Can we merge this and close the issue or should we get a second review? |
LGTM. If there are small changes in the future, we can push it directly or merge it after reviewed by one reviewer. |
cf #144
cc @jonocarroll
The script skips all lines after "upcoming events" (maybe not specific enough?) and removes the R code link.