Fix 1.63.0 MSRV #1993
Merged
Fix 1.63.0 MSRV #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
approved these changes
Oct 5, 2023
|
The only bummer is that adding Windows jobs makes CI much slower, there's less available :*( |
Hum, would you prefer me dropping |
|
Actually, I'm not sure which takes longer, Windows or Mac queues. But it's still waiting... I think I'd say let's just cut both of them, since this is a rare thing to catch anyways. What do you think? |
Alright, just seemed as other issues might also be overlooked due to the missing coverage. Will drop the second commit. |
tnull
force-pushed
the
2023-10-fix-msrv
branch
from
7dba03e
to
b1c729d
Compare
|
@seanmonstar Do you want me to include any further changes? |
kodiakhq bot
pushed a commit
to pdylanross/fatigue
that referenced
this pull request
Dec 19, 2023
Bumps reqwest from 0.11.22 to 0.11.23. Release notes Sourced from reqwest's releases. v0.11.23 What's Changed Add Proxy::custom_http_auth(val) for setting the raw Proxy-Authorization header when connecting to proxies. Fix redirect to reject locations that are not http:// or https://. Fix setting nodelay when TLS is enabled but URL is HTTP. (wasm) Add ClientBuilder::user_agent(val). (wasm) add multipart::Form::headers(headers). New Contributors @tnull made their first contribution in seanmonstar/reqwest#1993 @FirelightFlagboy made their first contribution in seanmonstar/reqwest#2018 @bitfl0wer made their first contribution in seanmonstar/reqwest#2036 @tshepang made their first contribution in seanmonstar/reqwest#2048 @Noah-Kennedy made their first contribution in seanmonstar/reqwest#2053 @abls made their first contribution in seanmonstar/reqwest#2062 @lorepozo made their first contribution in seanmonstar/reqwest#2064 @jan-auer made their first contribution in seanmonstar/reqwest#2068 Changelog Sourced from reqwest's changelog. v0.11.23 Add Proxy::custom_http_auth(val) for setting the raw Proxy-Authorization header when connecting to proxies. Fix redirect to reject locations that are not http:// or https://. Fix setting nodelay when TLS is enabled but URL is HTTP. (wasm) Add ClientBuilder::user_agent(val). (wasm) add multipart::Form::headers(headers). Commits 4f54ba7 v0.11.23 c65dd7f docs: add cfg notes about http3 builder methods (#2070) 6b901b1 Reject redirects with invalid scheme (#2068) ea59834 Update README advice regarding OpenSSL (#2064) 1485ce6 fix: set nodelay correctly to handle when a tls feature is enabled but connec... c09c5e6 proxy: add support for proxy authentication with user-specified header values... 4926d76 typo (#2048) 6792f69 fn headers() for wasm::multipart (#2036) 52190df http3: upgrade dependencies (#2028) 50dbaf3 docs: remove redundant link targets (#2019) Additional commits viewable in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot merge will merge this PR after your CI passes on it @dependabot squash and merge will squash and merge this PR after your CI passes on it @dependabot cancel merge will cancel a previously requested merge and block automerging @dependabot reopen will reopen this PR if it is closed @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
This was referenced Mar 11, 2024
Nutomic
pushed a commit
to Nutomic/reqwest
that referenced
this pull request
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, #1955 broke MSRV 1.63.0 as the
let Somesyntax wasn't stabilized until 1.65.0.This fixes the MSRV breakage on macOS.
As this had previously slipped the CI
msrvtest, the second commit now ensures we check MSRV onmacos-latestandwindows-latest, too.