Poll inner connection until EOF after gzip decoder is complete #2484
Conversation
| let stream_reader = gzip_decoder.get_mut(); | ||
| let peekable_io_stream = stream_reader.get_mut(); | ||
| match futures_core::ready!(Pin::new(peekable_io_stream).poll_next(cx)) { | ||
| Some(Ok(bytes)) => Poll::Ready(Some(Ok(Frame::data(bytes)))), |
There was a problem hiding this comment.
I think this is should likely be an error. If you said a response's content-encoding: gzip, it's assumed the entire content is encoded. If there's some dangling data that isn't, that seems bad.
There was a problem hiding this comment.
Could there be multiple consecutive chunks (Transfer-Encoding: chunked) in body?
And what about HTTP trailers?
There was a problem hiding this comment.
Yes, and most likely the compressed body came over multiple chunks. But content-encoding implies the entire content.
Trailers would come through as a different Frame, but the IoStream already tosses them. We could (in a separate PR, perhaps) reach into the IoStream and poll that instead, to support trailers.
There was a problem hiding this comment.
I mean, can it be like this?
|--------------original-content--------------------|
|-----gzip-content-1-----||-----gzip-content-2-----|
|-chunk-1-||---chunk-2---||----------chunk-3-------|
There was a problem hiding this comment.
If Some(Ok(bytes)) should return error, then what kind of error?
Fix for #2381