fix(core/select): added test for undefined select items #1568

matthiashader · 2024-11-20T08:53:34Z

💡 What is the current behavior?

before 1557 the select in angular throws an typeerror because of undefined values, this has already been fixed
test has been forgotten

GitHub Issue Number: #N/A, successor of #1557

🆕 What is the new behavior?

test added, that checks if a console.error occurs in the browser console
Note: Karma doesn't seem to have a nice way of waiting for class element, so a custom waitForHydration Method has been added, which cancels after 5 seconds - so the test is not infinite and also not flacky, when running only a defined amount of time

##Note

.componentOnReady was tested, but during runtime the error "componentOnReady" is not a function appeared
propaply jasmine / karmine is that fast that the component isn't fully loaded
when waiting e.g 1s before .componentOnReady, its defined
.whenStable / .detectChanges has been tested

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

🦮 Accessibility (a11y) features were implemented
🗺️ Internationalization (i18n) - no hard coded strings
📲 Responsiveness - components handle viewport changes and content overflow gracefully
📄 Documentation was reviewed/updated (pnpm run docs)
🧪 Unit tests were added/updated and pass (pnpm test)
📸 Visual regression tests were added/updated and pass (Guide)
🧐 Static code analysis passes (pnpm lint)
🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

changeset-bot · 2024-11-20T08:53:37Z

⚠️ No Changeset found

Latest commit: 5bbcacf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR