ci: run build workflow on external pull requests #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michaeladler Is this the solution you recently proposed? |
Currently we don't run the build workflow on external pull requests. This makes it tricky to detect build and style issues on these requests. As we already require explicit approval for all external contributors before running the action, it is fine to also enable the workflow. Further, I carefully checked the configuration of the repo with the poutine tool for possible bypasses. Signed-off-by: Felix Moessbauer <[email protected]>
fmoessbauer
force-pushed
the
fm/ci-run-on-pr
branch
from
d0bd45c
to
88483d3
Compare
| @@ -6,6 +6,9 @@ name: build browser extension | |||
|
|
|||
| on: | |||
| push: | |||
| branches: | |||
There was a problem hiding this comment.
Might wanna run it on all branches since it's cheap. Then you can write:
on: [push, pull_request, workflow_dispatch]
There was a problem hiding this comment.
But this makes it execute twice for PRs which are pushed to branches on this project.
fmoessbauer
requested review from
jan-kiszka
and removed request for
bufferoverflow
jan-kiszka
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we don't run the build workflow on external pull requests. This makes it tricky to detect build and style issues on these requests.
As we already require explicit approval for all external contributors before running the action, it is fine to also enable the workflow. Further, I carefully checked the configuration of the repo with the poutine tool for possible bypasses.