-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for multiple brims to exercise build agents #4836
base: master
Are you sure you want to change the base?
Conversation
Experimental implementation for #641 |
@@ -178,9 +178,14 @@ _constant() | |||
// TODO: status_cb | |||
Ref<ExtrusionEntityCollection> skirt() | |||
%code%{ RETVAL = &THIS->skirt; %}; | |||
Ref<ExtrusionEntityCollection> brim() | |||
Ref<std::vector<ExtrusionEntityCollection> > brim() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is probably useless now, but I am very bad at using XS to get a useful kind of reference.
✅ Build Slic3r 1.3.0-master-2347 completed (commit fc28ba8fbc by @lordofhyphens) |
I've long since sold my printer and am firmly on team close-that-original-issue. Thicker layers and support should solve most build issues for most people and if appearance is an issue, there are other ways to solve that. Just my 2c. Unfollowing since I don't have much else to offer here. |
This is a copy of a good gcode run, and a dodgy one. Seems like any change in the layout, or in skirt /brim options causes it to happen. This makes it incredibly difficult to use this release as after every change I need to close, re-add pieces, re-arrange, slice. If anything is NQR, repeat the process. The brims themselves are functionally everything I was hoping for. |
I did specifically say it was a hack. It is probably having to do with the fact that the slicing pathway wasn't written with multiple layer brims in mind so I didn't get all of the places that assumed it. |
@Pun-e export the plate with modifiers as 3mf or amf. It will be less of a headache to experiment with. |
And to reiterate, the units for this will always be in layers. If someone needs it in mm they can refactor the thing to get what they want, because getting the units to be in mm is way more work than I am willing to put into it. |
@lordofhyphens
The only ones I really need to be functional is the "cannot slice more than once due to moving parts". I have all my settings dialled in, start, load parts, slice. But if the brim, or skirt is too far, or some parts look iffy all I can do is try again from scratch. If I could just get more than one slice per load this would be more than enough for the limited times that I need this feature. The other major one is the inability to print more than one object at a time. The gcode looks fine, but for some reason my printer just never stops printing the brim. Have no idea if this is just me, or a bug with the slicer. |
Normal behavior re: brims printing first. Brims are generated first. It is not appropriate to request a change to that behavior here (out of scope). |
I'm sorry, I don't understand how this relates? |
Any updates on this? This would be an amazing feature to add, especially for the case mentioned above where the contact point between the brim and model is very weak, and adding additional layers may help it adhere better. |
DO NOT MERGE. The UI is not well-tested and this has not been proven to actually solve the underlying problem the feature was requested for.