Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve email validation in is-email-address method #3256

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

s21sd
Copy link

@s21sd s21sd commented Nov 24, 2024

Resolves #3132.

Description

What is the purpose of this pull request?

This pull request:

  • Fixes the issue with the is-email-address method, ensuring it correctly validates invalid email addresses according to standard email validation rules.
  • Adds comprehensive test cases to handle edge cases and improve reliability.

Related Issues

Does this pull request have any related issues?

This pull request:


Questions

Any questions for reviewers of this pull request?

No.


Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Before

Screenshot 2024-11-24 191819

After

after


Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the contributing guidelines.
  • Added new test cases to ensure proper validation functionality.
  • Verified that all existing tests pass without issues.

@stdlib-js/reviewers

Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
assert/is-email-address $\color{green}108/108$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}108/108$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte
Copy link
Member

kgryte commented Nov 24, 2024

Thank you for submitting this PR; however, it is not RFC 2822 compliant.

@kgryte kgryte added the Do Not Merge Pull request which should not be merged. label Nov 24, 2024
@kgryte kgryte changed the title fix: improve email validation in is-email-address method (#3132) fix: improve email validation in is-email-address method Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge Pull request which should not be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is-email-address method incorrectly validates invalid email addresses
3 participants