feat: add includes() method to array/fixed-endian-factory
#3283
+458
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib-bot
reviewed
Nov 27, 2024
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
@ahmad-kashkoush the title should start with "feat:" |
ahmad-kashkoush
changed the title
includes() method to array/fixed-endian-factoryincludes() method to array/fixed-endian-factory
Done, may you review PR? |
headlessNode
suggested changes
Nov 27, 2024
There was a problem hiding this comment.
@ahmad-kashkoush A few suggestions regarding the documentation, otherwise looks good. A more thorough review will be done by the maintainers. Also you should remove the parenthesis after includes in the title.
|
|
||
| #### TypedArrayFE.prototype.includes( searchElement\[, fromIndex] ) | ||
|
|
||
| Returns `true` if element can be found. |
There was a problem hiding this comment.
Suggested change
| Returns `true` if element can be found. | |
| Returns `true` if the specified `searchElement` is present in the array. |
| // returns true | ||
| ``` | ||
|
|
||
| If `searchElement` is not present in the array, the method returns `false`. |
There was a problem hiding this comment.
Suggested change
| If `searchElement` is not present in the array, the method returns `false`. | |
| If the specified `searchElement` is not present in the array, the method returns `false`. |
| @@ -675,6 +675,47 @@ function factory( dtype ) { // eslint-disable-line max-lines-per-function, stdli | |||
| } | |||
| return -1; | |||
| }); | |||
| /** | |||
| * A boolean value which is true if the value `searchElement` is found. | |||
There was a problem hiding this comment.
Suggested change
| * A boolean value which is true if the value `searchElement` is found. | |
| * Returns `true` if the specified `searchElement` is present in the array. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3145 .
Description
This pull request:
Related Issues
This pull request:
includesmethod toarray/fixed-endian-factory#3145Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers