Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making validate a prebuild step #38

Open
fishmonger45 opened this issue Jan 4, 2022 · 0 comments
Open

Consider making validate a prebuild step #38

fishmonger45 opened this issue Jan 4, 2022 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@fishmonger45
Copy link
Contributor

fishmonger45 commented Jan 4, 2022

Currently with dummy chain types file a project will build correctly but the project will not be valid to run. We should consider running validation before building.

To reproduce:

  1. Init a starter project
  2. Add an invalid chaintypes file (eg json) to the project manifest
  3. Build (yarn && yarn codegen && yarn build
  4. Build should work fine but when running subql validate it will fail

Solution:
Add a prebuild script to package.json which runs node dependencies subql validate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant