Display chaintypes error #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianhe8x
approved these changes
Jan 4, 2022
|
Good for now. @jiqiang90 when you work on the other refactory task, don't forget rebase this commit. |
bz888
pushed a commit
that referenced
this pull request
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display a swallowed chaintypes error that was only visible from
--debug. Quick fix for #727. Although doesn't move the validation logic toProjectManifestVersioned -> validate().In order to fix this further down the line we should consider adding validation as a prebuild step to the starter project so that invalid chain types result in a build error. Enhancement ticket about that here subquery/subql-starter#38