fix: corrected datetime serialisation #142
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
property based testing revealed a number of values that failed to maintain their value when round tripped through serialization/deserialization. This commit adds a property based test for datetime values and corrects the issue with serialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
property based testing revealed a number of values that failed to maintain their value when round tripped through serialization/deserialization. T
What is the motivation?
I required that data time values are consistent when serialised
What does this change do?
This commit adds a property based test for datetime values and corrects the issue with serialisation.
What is your testing strategy?
Added fscheck based tests for data time serialisation as well as a specific value sample. also added a specific value example in the database round trip tests for date time
Is this related to any issues?
addresses the date time portion of #138
Have you read the Contributing Guidelines?