-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update script to paginate request + init stars #436
Conversation
MacFJA
commented
Aug 13, 2023
- Script:
- Update the script to paginate request to avoid timeout from GitHub API.
- Sort result to ease stars file review and merge
- Provide a base stars count for all repos
✅ Deploy Preview for sveltesociety-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
(from #217 (comment)) 2 issues here:
|
thank you!! |
Thanks for this @MacFJA! We're getting closer, but I noticed a couple issues remaining. One was that it doesn't handle any repositories that have been renamed yet (e.g. the username changed or the repo was transferred to a GitHub org). I went ahead and updated the |
Yeah, In the past I was testing how to get data. One of my idea was to also retrieve information from NPM (if the package a well-defined, we have: name, description, repository, homepage, keywords, etc.). It could help to fill missing data. What we can also do is, instead of replacing with the file only, we can replace the star count if found in the file, or leave as-is from the |
There's not that many, so I don't mind filling in the missing GitHub URLs manually if we make the change I described above. |
Handled here: #438 |