-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: Update CMake.md to use the ABI entry point #828
Open
ADKaster
wants to merge
1
commit into
swiftlang:main
Choose a base branch
from
ADKaster:cmake-entry-point
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,21 +59,28 @@ endif() | |
## Add an entry point | ||
|
||
You must include a source file in your test executable target with a | ||
`@main` entry point. The following example uses the SwiftPM entry point: | ||
`@main` entry point. | ||
|
||
```swift | ||
import Testing | ||
import Foundation | ||
@_spi(ForToolsIntegrationOnly) import Testing | ||
|
||
@main struct Runner { | ||
static func main() async { | ||
await Testing.__swiftPMEntryPoint() as Never | ||
static func main() async throws { | ||
let configurationJSON: UnsafeRawBufferPointer? = nil | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can leave this line out and just pass |
||
let recordHandler: @Sendable (UnsafeRawBufferPointer) -> Void = { _ in } | ||
|
||
if try await ABIv0.entryPoint(configurationJSON, recordHandler) { | ||
exit(EXIT_SUCCESS) | ||
} else { | ||
exit(EXIT_FAILURE) | ||
} | ||
} | ||
} | ||
``` | ||
|
||
> [!WARNING] | ||
> The entry point is expected to change to an entry point designed for other | ||
> build systems prior to the initial stable release of Swift Testing. | ||
For more information on the input configuration and output records of the ABI entry | ||
point, refer to the [ABI documentation](ABI/JSON.md) | ||
|
||
## Integrate with CTest | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, yes-and-no. As we talked about in Slack, it's a bug that any
@_spi
content is available in the Swift toolchain right now and it's going to get removed in the future.For the moment, code should either use
dlsym()
/GetProcAddress()
or, if a little more adventurous, use the experimental@_extern(c)
to callswt_abiv0_getEntryPoint()
, then load the SwiftCC entry point from there. (@_silgen_name
could be used too, but technically the calling conventions are incompatible, so caveat codor.)We're still looking at how to expose these symbols in a way that makes it easy for test tools/harness authors but doesn't make the symbols visible to test authors by default. We're looking at adding a dedicated target in the package (if we can do so without requiring building the whole library from source) or creating a separate
swift-testing-tools-support
package, among other options.