Compatibility/Fix for symphony 2.6.x #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmifsud
changed the title
|
@alexnantel88 mind checking if you can replicate/confirm this? Can give steps is above is unclear. |
|
@jonmifsud I will check that out with @nitriques and come back to you. I am not personally aware of that, for the moment I am only preparing the 4.x version ;-) |
|
Thanks Jon. Would you mind adding a new version in the meta file please ? |
animaux
added a commit
to animaux/url_router
that referenced
this pull request
Jan 10, 2019
|
@nitriques this works fine and fixes issues for me! So here’s Jon’s fix plus the metafile update: #26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems there was a change somewhere in 2.6.x which impacted how this works from the core, by removing the
/at the start and end we match what the core provides within$route['original']