Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates required for tarantool/tarantool#9105 #424

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CuriousGeorgiy
Copy link
Member

❗ DO NOT MERGE BEFORE tarantool/luatest#355

This patch set bumps the luatest submodule and changes diff test execution to be compatible with tarantool/tarantool#9105.

Needed for tarantool/tarantool#9105

@CuriousGeorgiy CuriousGeorgiy added the do not merge Not ready to be merged label Feb 22, 2024
@CuriousGeorgiy CuriousGeorgiy force-pushed the diff-tests-box-error-serialization-verbose branch 2 times, most recently from ebcb0ef to f3b4096 Compare February 22, 2024 12:51
@coveralls
Copy link

coveralls commented Feb 22, 2024

Coverage Status

coverage: 62.58% (+0.04%) from 62.54%
when pulling bd5d71f on CuriousGeorgiy:diff-tests-box-error-serialization-verbose
into 434cbec on tarantool:master.

@CuriousGeorgiy CuriousGeorgiy force-pushed the diff-tests-box-error-serialization-verbose branch 3 times, most recently from 19a6443 to 5b683cb Compare February 22, 2024 19:10
New version includes the following commits.

- Change conversion of `box.error` to string in error message
  assertions [1]

[1] tarantool/luatest@xxx (WIP tarantool/luatest#355)
In scope of tarantool/tarantool#9105, we are going to increase the
verbosity of `box.error` serialization. Since the verbose error
representation contains the diagnostic trace, it is unsuitable for diff
tests, so let's disable it from the CLI.

Needed for tarantool/tarantool#9105
@CuriousGeorgiy CuriousGeorgiy force-pushed the diff-tests-box-error-serialization-verbose branch from 5b683cb to bd5d71f Compare February 22, 2024 23:35
@ylobankov ylobankov removed their assignment Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Not ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants