logrotate: don't exit at non-running instance #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elhimov
force-pushed
the
elhimov/gh-774-logrotate-exits-at-first-non-running-instance
branch
from
55bb68e
to
2aeec82
Compare
elhimov
force-pushed
the
elhimov/gh-774-logrotate-exits-at-first-non-running-instance
branch
2 times, most recently
from
7758f96
to
f99a646
Compare
- Added tests for the mentioned commands that check them against multi-instance and cluster (tarantool v3) apps - Implemented checking of various targets against various initial states - Careful checking of the command output and instances statuses (all instances are verified, not only related to involved targets)
For multi-instance applications no need to have instance scripts. For tarantool3-based applications no need to have cluster config. Closes #880
Just warn that the instance is not running and continue (like `tt stop` or `tt kill` do) Closes #774
elhimov
force-pushed
the
elhimov/gh-774-logrotate-exits-at-first-non-running-instance
branch
from
f99a646
to
573600a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just warn that the instance is not running and continue (like
tt stoportt killdo).Closes #774