Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github workflow option for trusted signing #3001

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

sandercox
Copy link

I guess I was developing this alongside with the work @Levminer has been doing. Trying to add the solution for this to the Docs I stumbled upon the new section that is only a week old with similar instructions.

The solution I appended is for people that want to just use GitHub actions for releasing their tooling and installs all the code for this in GitHub Actions only.

I personally made the signCommand config part of a override tauri.conf with production settings as I didn't want have the settings to codesign locally.

@Levminer did a great job but the wrapper tool in Rust is a bit overkill in my opinion and you still need all the other parts installed manually. I wasn't able to use the official TrustedSiging GitHub action either as I wasn't singing in their GitHub action, but wanted to invoke it from the Tauri side.

@sandercox sandercox requested a review from a team as a code owner November 19, 2024 10:59
Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for tauri-v2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5893ef0
🔍 Latest deploy log https://app.netlify.com/sites/tauri-v2/deploys/673ca981f2ddc9000830270d
😎 Deploy Preview https://deploy-preview-3001--tauri-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant