A couple minor fixes to DifferenceTemporalPlainYearMonth #3047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we use `yearMonth` here, we end up comparing the same dates.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3047 +/- ##
=======================================
Coverage 95.71% 95.71%
=======================================
Files 21 21
Lines 9704 9704
Branches 1742 1742
=======================================
Hits 9288 9288
Misses 364 364
Partials 52 52 ☔ View full report in Codecov by Sentry. |
…ation The `duration` value is already an Internal Duration Record, which is the type returned by RoundRelativeDuration (which does not have an internal slot of [[Duration]] anyhow).
trflynn89
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we use
yearMonthhere, we end up comparing the same dates.