-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import tests from SpiderMonkey #4106
base: main
Are you sure you want to change the base?
Conversation
Comparison of results between SpiderMonkey and V8
I've not looked at the 402 failures at all. |
9451f90
to
79e029d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am definitely not reviewing the giant automated import. But the other stuff around it looks good.
@@ -84,6 +84,10 @@ Atomics.pause | |||
# https://github.com/tc39/proposal-is-error | |||
Error.isError | |||
|
|||
# Records and Tuples | |||
# https://tc39.es/proposal-record-tuple/ | |||
record-tuple |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an interesting question, R&T is stage 2 and we generally don't want tests for stage 2 proposals yet. But I guess we can be more lenient about that since they are going to live in staging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah probably these should be omitted. The idea is still that staging only includes "correct" tests.
This code currently prevents tests from using |var join|.
No description provided.