Definitions for single activity API #440
Draft
+1,611
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ychebotarev
force-pushed
the
y_activity
branch
from
5c1ffab
to
37d5afc
Compare
Sushisource
reviewed
Aug 20, 2024
| @@ -835,4 +835,65 @@ service WorkflowService { | |||
| // aip.dev/not-precedent: We do not expose worker API to HTTP. --) | |||
| rpc RespondNexusTaskFailed(RespondNexusTaskFailedRequest) returns (RespondNexusTaskFailedResponse) { | |||
| } | |||
|
|
|||
| rpc UpdateActivity (UpdateActivityRequest) returns (UpdateActivityResponse) | |||
There was a problem hiding this comment.
I know it's still draft - but, to save you some time in the future I might suggest combining all of these into one RPC and using a oneof with an Operation message of some kind - since every request has the same 4 initial fields + identity.
Or, at minimum, wrap up the common fields in a message
There was a problem hiding this comment.
All those fields are "routing" fields, it is the same for every function we have (for activity is it more fields). That shouldn't be a reason to combine them. I prefer clarify (function name indicates the intent).
As for wrapping up - will do that.
There was a problem hiding this comment.
Suggested change
| rpc UpdateActivity (UpdateActivityRequest) returns (UpdateActivityResponse) | |
| rpc UpdateActivityOptions (UpdateActivityOptionsRequest) returns (UpdateActivityOptionsResponse) |
There was a problem hiding this comment.
(keeping this open)
alexshtin
reviewed
Aug 21, 2024
alexshtin
reviewed
Aug 21, 2024
alexshtin
reviewed
Aug 21, 2024
alexshtin
reviewed
Aug 21, 2024
alexshtin
reviewed
Aug 21, 2024
alexshtin
reviewed
Aug 21, 2024
alexshtin
reviewed
Aug 21, 2024
alexshtin
reviewed
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added definitions for single activity API.