Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring UI server host via an environment variable #294

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lminaudier
Copy link

What was changed

This PR adds a way to configure the UI server bind address / host using an environment variable. Right now you can configure the port using TEMPORAL_UI_PORT but not the host.

Why?

For consistency with the rest of the configuration options and to avoid having to use a configuration file just for one unexposed option.

Checklist

  1. Closes

  2. How was this tested:

Ran docker build

𝝺 docker build . -t test/ui-server

And checked setting the environment variable changed the output log showing the bind address

𝝺 docker run -it -e TEMPORAL_UI_HOST=127.0.0.1 test/ui-server
2023/06/13 10:27:21 Loading config; env=docker,configDir=config
2023/06/13 10:27:21 Loading config files=[config/docker.yaml]
...
⇨ http server started on 127.0.0.1:8080
  1. Any docs updates needed?

Maybe in another repo?

@feedmeapples
Copy link
Contributor

thx for the PR! could you open it here https://github.com/temporalio/ui. UI-server repo at this point just tracks & builds the changes in /ui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants