-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor: remove existing vpc endpoint configurations from base modul…
…e and move into sub-module BREAKING: VPC endpoint resources are removed in favor of sub-module and `for_each` creation of any VPC endpoints BREAKING: AWS provider has been updated from v2.70 to v3.15 for VPC endpoint changes and available attributes
- Loading branch information
1 parent
43edd44
commit bac41ed
Showing
60 changed files
with
1,504 additions
and
6,388 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
# Upgrade from v2.x to v3.x | ||
|
||
If you have any questions regarding this upgrade process, please consult the `examples` directory: | ||
|
||
- [Complete-VPC](https://github.com/terraform-aws-modules/terraform-aws-vpc/tree/master/examples/complete-vpc) | ||
|
||
If you find a bug, please open an issue with supporting configuration to reproduce. | ||
|
||
## List of backwards incompatible changes | ||
|
||
Previously, VPC endpoints were configured as standalone resources with their own set of variables and attributes. Now, this functionality is provided via a module which loops over a map of maps using `for_each` to generate the desired VPC endpoints. Therefore, to maintain the existing set of functionality while upgrading, you will need to perform the following changes: | ||
|
||
1. Move the endpoint resource from the main module to the sub-module. The example state move below is valid for all endpoints you might have configured (reference [`complete-vpc`](https://github.com/terraform-aws-modules/terraform-aws-vpc/tree/master/examples/complete-vpc) example for reference), where `ssmmessages` should be updated for and state move performed for each endpoint configured: | ||
|
||
``` | ||
tf state mv 'module.vpc.aws_vpc_endpoint.ssm[0]' 'module.vpc_endpoints.aws_vpc_endpoint.this["ssm"]' | ||
tf state mv 'module.vpc.aws_vpc_endpoint.ssmmessages[0]' 'module.vpc_endpoints.aws_vpc_endpoint.this["ssmmessages"]' | ||
tf state mv 'module.vpc.aws_vpc_endpoint.ec2[0]' 'module.vpc_endpoints.aws_vpc_endpoint.this["ec2"]' | ||
... | ||
``` | ||
|
||
2. Remove the gateway endpoint route table association separate resources. The route table associations are now managed in the VPC endpoint resource itself via the map of maps provided to the VPC endpoint sub-module. Perform the necessary removals for each route table association and for S3 and/or DynamoDB depending on your configuration: | ||
|
||
``` | ||
tf state rm 'module.vpc.aws_vpc_endpoint_route_table_association.intra_dynamodb[0]' | ||
tf state rm 'module.vpc.aws_vpc_endpoint_route_table_association.private_dynamodb[0]' | ||
tf state rm 'module.vpc.aws_vpc_endpoint_route_table_association.public_dynamodb[0]' | ||
... | ||
``` | ||
|
||
### Variable and output changes | ||
|
||
1. Removed variables: | ||
|
||
- `enable_*_endpoint` | ||
- `*_endpoint_type` | ||
- `*_endpoint_security_group_ids` | ||
- `*_endpoint_subnet_ids` | ||
- `*_endpoint_private_dns_enabled` | ||
- `*_endpoint_policy` | ||
|
||
2. Renamed variables: | ||
|
||
See the [VPC endpoint sub-module](modules/vpc-endpoints) for the more information on the variables to utilize for VPC endpoints | ||
|
||
- None | ||
|
||
3. Removed outputs: | ||
|
||
- `vpc_endpoint_*` | ||
|
||
4. Renamed outputs: | ||
|
||
VPC endpoint outputs are now provided via the VPC endpoint sub-module and can be accessed via lookups. See [`complete-vpc`](https://github.com/terraform-aws-modules/terraform-aws-vpc/tree/master/examples/complete-vpc) for further examples of how to access VPC endpoint attributes from outputs. | ||
|
||
- None |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.