Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] Provide delete Python package index endpoint #790

Open
5 tasks
fridex opened this issue Jun 28, 2021 · 11 comments
Open
5 tasks

[Epic] Provide delete Python package index endpoint #790

fridex opened this issue Jun 28, 2021 · 11 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@fridex
Copy link
Contributor

fridex commented Jun 28, 2021

Is your feature request related to a problem? Please describe.

As Thoth operator, I would like to have the ability to remove Python package index from Thoth deployment. As of now, I am able to disable an index, but it might be nice to also provide an ability to delete a Python package index and all the packages associated with it (decommission of an index).

Describe the solution you'd like

Create an endpoint for deleting a Python package index. This endpoint will trigger a workflow that will be responsible for deleting a Python package index. The async workflow handling is required as there might be associated thousands of packages with an index (it will require a lot of time to delete data from the database).

Additional context:

  • Knowledge of management-api
  • knowledge of thoth-storages for deleting the python package index using cascade method.
  • research on metrics that would need changes based on this.

Acceptance criteria

  • create an endpoint in management-api.
  • create truncate function for python package index in storages.
  • investigate which metrics needs update
  • implement the metrics changes
  • verify the whole feature.
@goern
Copy link
Member

goern commented Jun 28, 2021

/triage accepted
/priority important-longterm
/kind feature

@sesheta sesheta added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 28, 2021
@sesheta
Copy link
Member

sesheta commented Jul 28, 2021

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@sesheta sesheta closed this as completed Jul 28, 2021
@sesheta
Copy link
Member

sesheta commented Jul 28, 2021

@sesheta: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fridex fridex reopened this Jul 30, 2021
@sesheta
Copy link
Member

sesheta commented Aug 29, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@sesheta sesheta added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 29, 2021
@fridex
Copy link
Contributor Author

fridex commented Aug 30, 2021

/remove-lifecycle rotten
/triage accepted

@sesheta sesheta removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 30, 2021
@harshad16 harshad16 added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Sep 27, 2021
@goern
Copy link
Member

goern commented Apr 4, 2022

/sig devsecops
/priority backlog
/remove-priority important-longterm

@sesheta sesheta added sig/devsecops Categorizes an issue or PR as relevant to SIG DevSecOps. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Apr 4, 2022
@harshad16 harshad16 changed the title Provide delete Python package index endpoint [Epic] Provide delete Python package index endpoint Jun 6, 2022
@harshad16
Copy link
Member

/sig stack-guidance

@sesheta sesheta added the sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. label Jun 6, 2022
@harshad16 harshad16 removed the sig/devsecops Categorizes an issue or PR as relevant to SIG DevSecOps. label Jun 6, 2022
@mayaCostantini
Copy link
Contributor

/good-first-issue

@sesheta
Copy link
Member

sesheta commented Jun 27, 2022

@mayaCostantini:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 27, 2022
@mayaCostantini
Copy link
Contributor

As discussed during the SIG Stack Guidance meeting,
/assign @VannTen

@mayaCostantini mayaCostantini added lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. and removed lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. labels Jul 8, 2022
@VannTen
Copy link
Member

VannTen commented Jul 26, 2022

Regarding the two points concernings metrics, I'm not sure there is anything to
do (once the rest works).

AFAICT, this would affect metrics from the thoth-station/metrics-exporter (which
mostly translaste to DB/storages queries, if I'm not mistaken). But a quick look
don't reveal metrics depending on a particular index (nor should they).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: 📋 Backlog
Development

No branches or pull requests

6 participants