Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint to completely delete a Python index from Thoth storage #904

Closed
wants to merge 1 commit into from

Conversation

VannTen
Copy link
Member

@VannTen VannTen commented Jul 7, 2022

Related Issues and Dependencies

Required for #790

This introduces a breaking change

  • Yes
  • No

This Pull Request implements

Add endpoint to completely delete a Python index from Thoth storage.

Description

WIP


Rest will come later, but if the API endpoint looks bad, let me know.

Mimic the /python/package-index/state with adjustements for the
DELETE http method.
@sesheta sesheta added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2022
@sesheta
Copy link
Member

sesheta commented Jul 7, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign goern after the PR has been reviewed.
You can assign the PR to them by writing /assign @goern in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta
Copy link
Member

sesheta commented Jul 7, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 7, 2022
@goern goern closed this May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants