UX

messages/src/messages.ts

@@ -74,5 +74,28 @@ export const fileStats = z.object({
 })
 export type FileStats = z.infer<typeof fileStats>
 
+export const traceStart = z.object({
+  message: z.literal('traceStart'),
+})
+export type TraceStart = z.infer<typeof traceStart>
+
+export const traceStop = z.object({
+  message: z.literal('traceStop'),
+})
+export type TraceStop = z.infer<typeof traceStop>
+
 export type Message = z.infer<typeof message>
-export const message = z.union([ping, pong, gotoLocation, gotoPosition, traceFileChunk, traceFileEnd, traceFileStart, gotoTracePosition, positionTypeCounts, fileStats])
+export const message = z.union([
+  ping,
+  pong,
+  gotoLocation,
+  gotoPosition,
+  traceFileChunk,
+  traceFileEnd,
+  traceFileStart,
+  gotoTracePosition,
+  positionTypeCounts,
+  fileStats,
+  traceStart,
+  traceStop,
+])

package.json

@@ -32,7 +32,7 @@
   ],
   "contributes": {
     "configuration": {
-      "title": "tsperf.tracer",
+      "title": "TsPerf Tracer",
       "properties": {
         "tsperf.tracer.typescriptPathMode": {
           "type": "string",
@@ -49,42 +49,212 @@
             "VsCode TSDK setting",
             "node_modules in you project",
             "Use tracer TypeScript path setting"
-          ]
+          ],
+          "order": 0
         },
         "tsperf.tracer.traceCmd": {
           "type": "string",
           "default": "npx tsc --generateTrace ${traceDir}",
-          "description": "command to generate tsc traces"
+          "description": "command to generate tsc traces",
+          "order": 1
         },
         "tsperf.tracer.typescriptPath": {
           "type": "string",
           "default": "",
-          "description": "Path to TypeScript. Must be specified if 'Use TypeScript from' is 'Use tracer TypeScript path setting'"
+          "description": "Path to TypeScript. Must be specified if 'Use TypeScript from' is 'Use tracer TypeScript path setting'",
+          "order": 2
         },
         "tsperf.tracer.benchmarkIterations": {
           "type": "number",
           "default": 3,
-          "description": "Higher values reduce variance but increase benchmarking time"
+          "description": "Higher values reduce variance but increase benchmarking time",
+          "order": 3
         },
         "tsperf.tracer.restartTsserverOnIteration": {
           "type": "boolean",
           "default": false,
-          "description": "Restart tsserver on each iteration to avoid caching influincing measurements"
+          "description": "Restart tsserver on each iteration to avoid caching influincing measurements",
+          "order": 4
         },
         "tsperf.tracer.allIdentifiers": {
           "type": "boolean",
           "default": false,
-          "description": "Benchmark all allIdentifiers or only the first of each statement"
+          "description": "Benchmark all allIdentifiers or only the first of each statement",
+          "order": 5
+        },
+        "tsperf.tracer.traceTimeThresholds": {
+          "type": "object",
+          "properties": {
+            "info": {
+              "type": "number"
+            },
+            "warning": {
+              "type": "number"
+            },
+            "error": {
+              "type": "number"
+            }
+          },
+          "required": [
+            "info",
+            "warning",
+            "error"
+          ],
+          "additionalProperties": false,
+          "default": {
+            "info": 1,
+            "warning": -1,
+            "error": -1
+          },
+          "description": "todo",
+          "order": 6,
+          "markdownDescription": "# Trace Time Thresholds\n\nTrigger diagnostics from trace files when check time in ms exceeds these thresholds.\n\n* -1 will disable diagnostics of that severity\n"
+        },
+        "tsperf.tracer.traceTypeThresholds": {
+          "type": "object",
+          "properties": {
+            "info": {
+              "type": "number"
+            },
+            "warning": {
+              "type": "number"
+            },
+            "error": {
+              "type": "number"
+            }
+          },
+          "required": [
+            "info",
+            "warning",
+            "error"
+          ],
+          "additionalProperties": false,
+          "default": {
+            "info": 1,
+            "warning": -1,
+            "error": -1
+          },
+          "description": "todo",
+          "order": 7,
+          "markdownDescription": "# Trace Type Thresholds\n\nTrigger diagnostics from trace files when the number of types created locally in this check call exceeds these thresholds.\n\n* -1 will disable diagnostics of that severity\n"
+        },
+        "tsperf.tracer.traceTotalTypeThresholds": {
+          "type": "object",
+          "properties": {
+            "info": {
+              "type": "number"
+            },
+            "warning": {
+              "type": "number"
+            },
+            "error": {
+              "type": "number"
+            }
+          },
+          "required": [
+            "info",
+            "warning",
+            "error"
+          ],
+          "additionalProperties": false,
+          "default": {
+            "info": 1,
+            "warning": -1,
+            "error": -1
+          },
+          "description": "todo",
+          "order": 8,
+          "markdownDescription": "# Trace Total Type Thresholds\n\nTrigger diagnostics from trace files when the number of types created in this check call stack exceeds these thresholds.\n\n* -1 will disable diagnostics of that severity\n"
+        },
+        "tsperf.tracer.traceDiagnosticsRelative": {
+          "type": "boolean",
+          "default": false,
+          "description": "Use measurements relative to the average for trace diagnostics",
+          "order": 9
+        },
+        "tsperf.tracer.traceTimeRelativeThresholds": {
+          "type": "object",
+          "properties": {
+            "info": {
+              "type": "number"
+            },
+            "warning": {
+              "type": "number"
+            },
+            "error": {
+              "type": "number"
+            }
+          },
+          "required": [
+            "info",
+            "warning",
+            "error"
+          ],
+          "additionalProperties": false,
+          "default": {
+            "info": 1,
+            "warning": -1,
+            "error": -1
+          },
+          "description": "todo",
+          "order": 10
+        },
+        "tsperf.tracer.traceTypeRelativeThresholds": {
+          "type": "object",
+          "properties": {
+            "info": {
+              "type": "number"
+            },
+            "warning": {
+              "type": "number"
+            },
+            "error": {
+              "type": "number"
+            }
+          },
+          "required": [
+            "info",
+            "warning",
+            "error"
+          ],
+          "additionalProperties": false,
+          "default": {
+            "info": 1,
+            "warning": -1,
+            "error": -1
+          },
+          "description": "todo",
+          "order": 11
+        },
+        "tsperf.tracer.traceTotalTypeRelativeThresholds": {
+          "type": "object",
+          "properties": {
+            "info": {
+              "type": "number"
+            },
+            "warning": {
+              "type": "number"
+            },
+            "error": {
+              "type": "number"
+            }
+          },
+          "required": [
+            "info",
+            "warning",
+            "error"
+          ],
+          "additionalProperties": false,
+          "default": {
+            "info": 1,
+            "warning": -1,
+            "error": -1
+          },
+          "description": "todo",
+          "order": 12
         }
       }
     },
-    "commandPalette": [
-      {
-        "command": "tsperf.tracer.sendTrace",
-        "when": "!notebookEditorFocused && editorLangId == 'json'",
-        "group": "tracer"
-      }
-    ],
     "commands": [
       {
         "command": "tsperf.tracer.gotoTracePosition",
@@ -93,29 +263,46 @@
       },
       {
         "command": "tsperf.tracer.openInBrowser",
-        "title": "Open trace view in browser",
-        "category": "Tracer",
+        "title": "Open trace viewer",
         "icon": {
           "dark": "resources/todo.svg",
           "light": "resources/todo.svg"
-        }
+        },
+        "category": "Tracer"
       },
       {
         "command": "tsperf.tracer.runTrace",
         "title": "tsc trace",
-        "category": "Tracer",
         "icon": {
           "dark": "resources/todo.svg",
           "light": "resources/todo.svg"
-        }
+        },
+        "category": "Tracer"
       },
       {
         "command": "tsperf.tracer.sendTrace",
         "title": "Send Trace to Trace Viewer",
-        "when": "!notebookEditorFocused && editorLangId == 'json'",
         "category": "Tracer"
       }
-    ]
+    ],
+    "menus": {
+      "commandPalette": [
+        {
+          "command": "tsperf.tracer.sendTrace",
+          "title": "Send Trace to Trace Viewer",
+          "when": "!notebookEditorFocused && editorLangId == 'json'",
+          "category": "Tracer"
+        }
+      ],
+      "explorer/context": [
+        {
+          "command": "tsperf.tracer.sendTrace",
+          "title": "Send Trace to Trace Viewer",
+          "when": "resourceFilename =~ /.*((trace)|(types)).*.json/",
+          "category": "Tracer"
+        }
+      ]
+    }
   },
   "scripts": {
     "generate:contributes": "jiti ./scripts/generate-contributes.ts",

scripts/configDescriptions/traceTimeThresholds.md

@@ -0,0 +1,5 @@
+# Trace Time Thresholds
+
+Trigger diagnostics from trace files when check time in ms exceeds these thresholds.
+
+* -1 will disable diagnostics of that severity

scripts/configDescriptions/traceTotalTypeThresholds.md

@@ -0,0 +1,5 @@
+# Trace Total Type Thresholds
+
+Trigger diagnostics from trace files when the number of types created in this check call stack exceeds these thresholds.
+
+* -1 will disable diagnostics of that severity

scripts/configDescriptions/traceTypeThresholds.md

@@ -0,0 +1,5 @@
+# Trace Type Thresholds
+
+Trigger diagnostics from trace files when the number of types created locally in this check call exceeds these thresholds.
+
+* -1 will disable diagnostics of that severity